fix(iOS): dispatch completion to main thread in handlePreloadedImage#222
Merged
fix(iOS): dispatch completion to main thread in handlePreloadedImage#222
Conversation
mfazekas
force-pushed
the
fix/ios-preloaded-image-dispatch-crash
branch
from
4506a15 to
aba5a82
Compare
handlePreloadedImage was calling completion() synchronously on the Rive C++ runtime's background import queue, but completion triggers releaseFile() which asserts main thread via dispatchPrecondition.
mfazekas
force-pushed
the
fix/ios-preloaded-image-dispatch-crash
branch
from
aba5a82 to
6d459c9
Compare
mfazekas
pushed a commit
that referenced
this pull request
Apr 23, 2026
🤖 I have created a release *beep* *boop* --- ## [0.4.6](v0.4.5...v0.4.6) (2026-04-23) ### Bug Fixes * **iOS:** dispatch completion to main thread in handlePreloadedImage ([#222](#222)) ([5c043d4](5c043d4)) * prevent crash when React Fabric diffs props on disposed HybridObject ([#227](#227)) ([8286bcf](8286bcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221
handlePreloadedImagewas callingcompletion()synchronously on the Rive C++ runtime's background import queue, butcompletiontriggersreleaseFile()which asserts main thread viadispatchPrecondition. Every other asset path inReferencedAssetLoaderalready dispatches to main before callingcompletion()— this was the only one missing it.Crash stack (reproduced locally)
Reproduced using the Out-of-Band Assets (Suspense) exerciser which calls
RiveImages.loadFromURLAsyncand passes the preloadedRiveImageviareferencedAssets.