feat: upgrade to xrpld 3.2.0 - #45
Merged
Merged
Conversation
gh release create reproduces the exact same behavior (title, generated notes, prerelease/latest flags) using a tool already present on every GitHub-hosted runner, removing one more third-party action from the release pipeline's trust boundary. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Per Ajit's release sign-off feedback in #xrpl-devnets: this is a developer tool for local/Devnet/Testnet use, not a mainnet-safe wallet — it doesn't provide the private-key security practices real fund custody requires. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lumes Records which image last started the persistent --local-network volumes (~/.xrpl-up/local-network-image.txt) and blocks start with a clear error if a different image is used against a volume that still has data — matching real precedent from the 3.1.x -> 3.2.0 upgrade, which moved the DB/log paths and silently broke existing volumes. Only triggers when there's actual data at risk (fresh volumes have nothing to conflict with) and only against a previously recorded image (older xrpl-up versions never wrote this file, so upgrading xrpl-up itself doesn't spuriously block). `xrpl-up reset` clears the record since it also wipes the volumes. Verified live: mismatched image blocks with a clear message pointing to `xrpl-up reset`; reset clears the record; same-image restart and fresh-after-reset starts both work without a false positive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Genericize the comment and the user-facing error message — the guard handles any image mismatch, not just that one past incident. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Cross-verified every command against actual CLI source and live Docker testing. Fixes include: renamed/removed commands (`xrpl-up node` → `start --detach`, `faucet --local` → `faucet --network local`), wrong flag names (--authorize vs --auth, --amount1/--fee vs --amount/--trading-fee), positional args where flags are required, missing required companion flags (--confirm, --balance, --transferable), false "auto-funds a wallet" claims, and one fully fictional command (accountset signer-list). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fix outdated/fictional command syntax in example docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-opening PR #43 (which shows "Merged" from an earlier merge-then-revert cycle — that revert was to back out an unintended direct merge, not a rejection of the work; see #43 for full history).
xrpllabsofficial/xrpld:3.2.0torippleci/xrpld:3.2.0(org the team controls directly)xrpllabsofficialimagesundiciimplicated in real-network e2e flakiness)Test plan
🤖 Generated with Claude Code