Skip to content

Make Lending setup compatible with LendingProtocolV1_1 - #98

Merged
manasip-prog merged 4 commits into
mainfrom
manasip/fix-lending-v1_1-setup
Sep 9, 2026
Merged

manasip-prog merged 4 commits into
mainfrom
manasip/fix-lending-v1_1-setup

Conversation

@manasip-prog

@manasip-prog manasip-prog commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes Lending setup and role signatures for LendingProtocolV1_1 and fixCleanup3_4_0, required for the 3.4.0 Antithesis run.

The amendment requires closed-ended Vaults for new Loan Brokers. Additionally, fixCleanup3_4_0 binds counterparty and sponsor signatures to dedicated prefixes; xrpl-py 5.1.0 still signs both with the legacy transaction prefix, causing Counterparty: Invalid signature.

Changes

  • Create dedicated XRP lending Vaults as closed-ended.
  • Keep them in Subscription long enough for setup deposits, then wait for Investment before creating loans.
  • Restrict valid Loan Broker and Loan paths to eligible Vaults and schedules.
  • Sign CounterpartySignature with CPT\0 and SponsorSignature with SPN\0.
  • Share the role-signing implementation across setup, lending, sponsorship, and modifiers.
  • Ignore generated root testnet/ output.

Validation

  • Deterministic cryptographic verification for both 3.4 role prefixes
  • check-imports
  • check-endpoints
  • check-fuzz-coverage
  • check-modifier-coverage
  • Ruff lint and format
  • mypy
  • basedpyright

@manasip-prog
manasip-prog marked this pull request as ready for review September 8, 2026 22:46
@lmaisons
lmaisons self-requested a review September 9, 2026 16:00

@lmaisons lmaisons left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out as problematic. Fixes a blocking problem. Approving.

@manasip-prog
manasip-prog merged commit 55ff256 into main Sep 9, 2026
1 check passed
@manasip-prog
manasip-prog deleted the manasip/fix-lending-v1_1-setup branch September 9, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants