simpleXRPL docs - #224
Conversation
|
|
||
| // Palisade — authenticates via OAuth client credentials and acts on a | ||
| // specific vault/wallet. | ||
| const palisade = await PalisadeCustody.create({ |
There was a problem hiding this comment.
just confirming that it's correct that we have no url for ripple custody but we do for palisade? @pdp2121
There was a problem hiding this comment.
Yes that's correct afaik. Cant tag Cybele here to confirm
There was a problem hiding this comment.
Just added her to review team, tagging @cybele-ripple
maria-robobug
left a comment
There was a problem hiding this comment.
Added mostly some style and formatting comments.
One thing to note, I think the use of "Token" for MPTs is confusing, but I get that this is how it's been implemented. It would be good if we could keep some of the terminology consistent with xrpl.org to avoid confusion.
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
maria-robobug
left a comment
There was a problem hiding this comment.
Added mostly some style and formatting comments.
One thing to note, I think the use of "Token" for MPTs is confusing, but I get that this is how it's been implemented. It would be good if we could keep some of the terminology consistent with xrpl.org to avoid confusion.
This PR adds these
simpleXRPLSDK docs: