Use verify_request_format! method to check valid request format#96
Open
fpenapita wants to merge 1 commit intorichpeck:masterfrom
Open
Use verify_request_format! method to check valid request format#96fpenapita wants to merge 1 commit intorichpeck:masterfrom
fpenapita wants to merge 1 commit intorichpeck:masterfrom
Conversation
This commit fix a problem to be able to render error responses for format distinct to html (for example json) because e.request.format is returning a Mime::Type object that doesn’t match with the values in self.class.respond_to that is a hash with keys :html, :json, etc Using the responders’ verify_requested_format! we are getting exactly the same goal delegating the tasks in the own responders gem.
Pull Request Test Coverage Report for Build 1565
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1565
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix a problem to be able to render error responses for
format distinct to html (for example json) because e.request.format is
returning a Mime::Type object that doesn’t match with the values in
self.class.respond_to that is a hash with keys :html, :json, etc
Using the responders’ verify_requested_format! we are getting exactly
the same goal delegating the tasks in the own responders gem.