Configurable Knex session clear interval#7916
Open
dlakatos847 wants to merge 1 commit intorequarks:mainfrom
Open
Configurable Knex session clear interval#7916dlakatos847 wants to merge 1 commit intorequarks:mainfrom
dlakatos847 wants to merge 1 commit intorequarks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running wiki.js on certain platforms requires the ability to fine-tune database interactions. E.g. DaaS like AWS RDS bills its customers based on consumed ACUs, which theoretically could be around zero running an unused wiki.js instance. Since Knex clears stale sessions periodically, which job opens database connections and performs database operations, achieving near-zero ACU consumtion is impossible.
Wiki.js currently uses Knex with its default settings which triggers the clear job every 60 000 ms. This contribution allows users to override this interval to anything they like but leaves the default value in place.