Skip to content

EPMRPP-116077 || Drop Mobitru URL from global and project integration form extension#17

Merged
siarheirazuvalau merged 1 commit into
developfrom
feature/EPMRPP-116077-drop-mobitru-url-from-integration-settings
May 28, 2026
Merged

EPMRPP-116077 || Drop Mobitru URL from global and project integration form extension#17
siarheirazuvalau merged 1 commit into
developfrom
feature/EPMRPP-116077-drop-mobitru-url-from-integration-settings

Conversation

@siarheirazuvalau

@siarheirazuvalau siarheirazuvalau commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements EPMRPP-116077 in the Mobitru plugin UI extension. Global and project integration flows now collect only API key and Mobitru Billing unit (slug), per US-PLG-MOB-002 and US-PRJ-INT-001. The Mobitru URL field, HTTPS URL validation, and URL display in the integration settings auth summary are removed. Create and update payloads from this extension no longer include url.

Backend handling of a fixed Mobitru API base URL is out of scope for this PR.

Changes

Remove the url field and HTTPS validators from MobitruFormFields (used in Create Global Integration, Create Project Integration, and edit modals via addIntegrationModal).
Remove URL from the read-only auth fields block in MobitruSettings.
Drop unused integration messages (Mobitru URL, invalid URL / HTTPS URL).
Remove url from MobitruIntegrationParameters TypeScript type.

Summary by CodeRabbit

  • Bug Fixes
    • Removed the URL field from Mobitru integration configuration. The form now requires only API Key and Billing Unit settings.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 88917c5a-1926-44ed-9c03-2d52cc0c55f5

📥 Commits

Reviewing files that changed from the base of the PR and between 2738783 and d3280c9.

📒 Files selected for processing (4)
  • ui/src/components/mobitruFormFields/mobitruFormFields.tsx
  • ui/src/components/mobitruSettings/mobitruSettings.tsx
  • ui/src/messages/integration.ts
  • ui/src/types/extensionProps/common/index.ts
💤 Files with no reviewable changes (4)
  • ui/src/components/mobitruSettings/mobitruSettings.tsx
  • ui/src/types/extensionProps/common/index.ts
  • ui/src/components/mobitruFormFields/mobitruFormFields.tsx
  • ui/src/messages/integration.ts

Walkthrough

This PR removes the url field and its associated HTTPS-URL validation from the Mobitru integration across the entire stack: type contract, localized messages, form field rendering, validation logic, and settings display configuration.

Changes

Mobitru URL Field Removal

Layer / File(s) Summary
Type definition update
ui/src/types/extensionProps/common/index.ts
Remove the optional url property from MobitruIntegrationParameters interface; contract now includes only apiKey and billingUnit.
Message descriptor cleanup
ui/src/messages/integration.ts
Remove message entries for url, invalidUrl, and invalidHttpsUrl from the exported messages object, keeping only apiKey and billingUnit descriptors.
Form field and validation removal
ui/src/components/mobitruFormFields/mobitruFormFields.tsx
Remove validateHttpsUrl callback validator and the rendered url FieldElement; form fields now start with apiKey.
Settings configuration update
ui/src/components/mobitruSettings/mobitruSettings.tsx
Remove the url field entry from authFieldsConfig array, leaving only masked apiKey and billingUnit display entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • reportportal/plugin-mobitru#9: Both PRs modify the Mobitru integration UI by changing form fields, settings, and messages around the url field and HTTPS URL validation—one adds these features while the other removes them.
  • reportportal/plugin-mobitru#8: Directly conflicts with this PR's removal of url field, HTTPS-URL validation, and message descriptors across the same files where PR #8 added them.
  • reportportal/plugin-mobitru#3: Overlaps at the form-field level by modifying MobitruFormFields' handling of the integration url input.

Suggested reviewers

  • allaprischepa

Poem

🐰 The URL vanishes clean, field by field,
Type and message, form and shield,
What once required a link so grand,
Now needs just keys in Mobitru's land! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removal of the Mobitru URL field from integration forms, which aligns perfectly with the changeset scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/EPMRPP-116077-drop-mobitru-url-from-integration-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@siarheirazuvalau siarheirazuvalau merged commit 4c3d74b into develop May 28, 2026
3 checks passed
@siarheirazuvalau siarheirazuvalau deleted the feature/EPMRPP-116077-drop-mobitru-url-from-integration-settings branch May 28, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants