Skip to content

EPMRPP-114990 || Fix plyr icons loading in prod#15

Merged
AmsterGet merged 2 commits into
developfrom
bugfix/EPMRPP-114990-fix-plyr-icons-loading-in-prod
May 25, 2026
Merged

EPMRPP-114990 || Fix plyr icons loading in prod#15
AmsterGet merged 2 commits into
developfrom
bugfix/EPMRPP-114990-fix-plyr-icons-loading-in-prod

Conversation

@AmsterGet

@AmsterGet AmsterGet commented May 25, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation

    • Expanded local development setup documentation with detailed configuration examples, dev server guidance, local asset serving instructions, and proxy configuration options for the plugin UI.
  • Chores

    • Refactored player asset configuration to dynamically retrieve URLs from extension settings. Updated build pipeline to properly include and serve Plyr icon assets.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AmsterGet, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 26 minutes and 39 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3dcde49b-c895-41fd-aba1-3c0c53f93f5e

📥 Commits

Reviewing files that changed from the base of the PR and between 9449ed1 and ee4d160.

📒 Files selected for processing (2)
  • ui/src/constants/common.ts
  • ui/src/hooks/useCommandExecutor.ts

Walkthrough

The PR enables dynamic Plyr player icon loading by extending the extension API with an asset URL resolver, updating the component to compute player options at runtime using that API, configuring the build to copy the icon asset, and documenting the development workflow.

Changes

Dynamic Plyr Icon Loading

Layer / File(s) Summary
Extension API contract for plugin assets
ui/src/types/extensionProps/utils/index.ts
UtilsInterface.URLS gains a new pluginPublicFile(pluginName, fileKey) method that returns asset URLs.
Dynamic player options computation and component updates
ui/src/constants/common.ts, ui/src/components/remoteDeviceTab/remoteDeviceTab.tsx
PLUGIN_NAME constant is defined; static PLAYER_OPTIONS is split into BASE_PLAYER_OPTIONS and a memoized playerOptions object that derives iconUrl from the extension API; component prop typing is updated to ExtensionProps & LogTabProps.
Asset build configuration
ui/webpack.config.js
Webpack CopyPlugin is configured to copy plyr.svg from node_modules/plyr/dist/ into the build output directory.
Local development and asset loading documentation
ui/README.md
README is expanded with local development setup instructions using window.RP.overrideExtension, an optional proxy workflow, and documentation of how static assets are resolved at runtime in dev and production environments.

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • reportportal/plugin-mobitru#13: Introduces window.RP.overrideExtension('mobitru', 'http://localhost:9090') pattern that this PR builds upon in expanded local development documentation.

Suggested reviewers

  • allaprischepa
  • VaheSamsonyan
  • siarheirazuvalau

Poem

🐰 A Plyr icon takes the stage,
No longer bound by static cage,
From URLS the path now flows,
Through memoized logic it grows,
Webpack copies, docs align—
Dynamic assets now shine! 🎭✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing plyr icons loading in production, which is directly addressed through the webpack copy configuration and dynamic URL construction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/EPMRPP-114990-fix-plyr-icons-loading-in-prod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/README.md`:
- Around line 40-42: The fenced code block containing the PROXY_PATH example is
missing a language tag and triggers markdownlint MD040; update the
triple-backtick fence to include a language (e.g., "bash") so it reads ```bash
before the environment line (reference: the fenced block around PROXY_PATH in
ui/README.md) to satisfy the linter.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 896ac7b4-79f3-45f8-af32-ba710b2e99a5

📥 Commits

Reviewing files that changed from the base of the PR and between 712da88 and 9449ed1.

📒 Files selected for processing (5)
  • ui/README.md
  • ui/src/components/remoteDeviceTab/remoteDeviceTab.tsx
  • ui/src/constants/common.ts
  • ui/src/types/extensionProps/utils/index.ts
  • ui/webpack.config.js

Comment thread ui/README.md
@AmsterGet AmsterGet merged commit 8688a04 into develop May 25, 2026
3 checks passed
@AmsterGet AmsterGet deleted the bugfix/EPMRPP-114990-fix-plyr-icons-loading-in-prod branch May 25, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants