Skip to content

generate new endpoints#1114

Open
gabrielseco wants to merge 12 commits into
mainfrom
pbyr-4192-fe-use-new-endpoints
Open

generate new endpoints#1114
gabrielseco wants to merge 12 commits into
mainfrom
pbyr-4192-fe-use-new-endpoints

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Touches onboarding compliance/signing flows and swaps API contracts consumers rely on; risk is moderated because much of the change is generated client surface plus example UI wiring.

Overview
Regenerates the OpenAPI client around a unified pre-onboarding requirements model: list requirements, create documents per requirement slug, and acknowledge / delete acknowledgement via new endpoints (replacing the older document-requirements-only surface). Exports and types rename accordingly (PreOnboardingRequirement, etc.), with additional unrelated generated routes (WD GPH pay, timesheets, oauth token variant).

The example onboarding app turns on the pre_onboarding_requirements feature and updates the review step to render document vs acknowledgement requirements separately. Document flows no longer gate on inline “constraints ack” or pass document_constraints_ack_at when creating documents; blocked dependencies use a shared tooltip that wording depends on requirement type. Acknowledgement requirements call onAcknowledgeRequirement with lock/pending states from the flows bag, and render HTML descriptions via transformHtmlToComponents.

Generated client bootstrap drops the hardcoded gateway baseUrl on the default client instance.

Reviewed by Cursor Bugbot for commit a18eb02. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 224.25 kB 223.95 kB +303 B (+0.1%) 🔴
Total (raw) 602.01 kB 604.77 kB -2.76 kB (-0.5%) 🟢
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 224.25 kB / 250 kB (89.7%)
  • ✅ Total raw: 602.01 kB / 650 kB (92.6%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-2NHQ6VNQ.js - 6.36 kB (new)
  5. index.js - 6.33 kB (+1 B (+0.0%))
View All Files (341 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-2NHQ6VNQ.js 6.36 kB new
index.js 6.33 kB +1 B (+0.0%)
chunk-EQASR5TY.js 6.04 kB new
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-IKWANW2K.js 4.76 kB new
chunk-WGQFYLFB.js 4.57 kB new
chunk-QAYYVUKV.js 3.89 kB new

✅ Bundle size check passed

},
},
});
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSW mocks use outdated endpoints

Medium Severity

This commit switches pre-onboarding hooks to generated routes under pre-onboarding-requirements (including {requirement_slug}/documents), but default MSW handlers and test overrides still mock the removed pre-onboarding-document-requirements and pre-onboarding-documents paths, so mocked requests never match and PreOnboarding tests fail.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 32f7f31. Configure here.

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx Outdated
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread example/src/ReviewOnboardingStep.tsx
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-mp4a967tr-remotecom.vercel.app
Latest Commit:a18eb02

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-6z3cynphf-remotecom.vercel.app
Latest Commit:a18eb02

Deployed with vercel-action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a988111. Configure here.

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant