Skip to content

images: fix the module usage example - #279

Merged
lubomir merged 1 commit into
release-engineering:masterfrom
prownd:images-fix-the-module-usage-example-s01
Oct 29, 2026
Merged

lubomir merged 1 commit into
release-engineering:masterfrom
prownd:images-fix-the-module-usage-example-s01

Conversation

@prownd

@prownd prownd commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

The example iterated over compose.images.images[variant].values() inside the arch loop and then used an undefined variable "image". It also printed the result twice with broken indentation and described the set as a list. Fix the loop and tidy the example.

The example iterated over compose.images.images[variant].values()
inside the arch loop and then used an undefined variable "image". It
also printed the result twice with broken indentation and described the
set as a list. Fix the loop and tidy the example.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.92%. Comparing base (b01c4cf) to head (a03ed6d).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   79.71%   79.92%   +0.20%     
==========================================
  Files          10       10              
  Lines        2061     2062       +1     
==========================================
+ Hits         1643     1648       +5     
+ Misses        418      414       -4     
Flag Coverage Δ
unit-tests 79.92% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
productmd/images.py 97.63% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lubomir
lubomir merged commit dfba6a5 into release-engineering:master Oct 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants