Repository navigation
common: fix catastrophic backtracking in release regexes - #272
Merged
lubomir merged 1 commit intoOct 23, 2026
Conversation
RELEASE_SHORT_RE, RELEASE_TYPE_RE and RELEASE_VERSION_RE contained nested quantifiers (`([a-z0-9]*-?[a-z0-9]+)*` and `(\.?[0-9]+)*`). On a long non-matching input the regex engine backtracks exponentially: validating a release short name of 22 letters followed by "!" took more than 75 seconds. RELEASE_VERSION_RE is applied to the version field when deserializing composeinfo.json, which may be fetched from a remote server, so a crafted metadata file can hang any consumer (ReDoS). Rewrite the expressions without nested quantifiers. The accepted language is unchanged (verified by exhaustively comparing old and new expressions on all strings up to 8 characters over a representative alphabet).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 10 10
Lines 2061 2061
=======================================
Hits 1643 1643
Misses 418 418
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the patch. |
lubomir
added
the
sync development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE_SHORT_RE, RELEASE_TYPE_RE and RELEASE_VERSION_RE contained nested quantifiers (
([a-z0-9]*-?[a-z0-9]+)*and(\.?[0-9]+)*). On a long non-matching input the regex engine backtracks exponentially: validating a release short name of 22 letters followed by "!" took more than 75 seconds.RELEASE_VERSION_RE is applied to the version field when deserializing composeinfo.json, which may be fetched from a remote server, so a crafted metadata file can hang any consumer (ReDoS).
Rewrite the expressions without nested quantifiers. The accepted language is unchanged (verified by exhaustively comparing old and new expressions on all strings up to 8 characters over a representative alphabet).