docs: comprehensive AWS Bedrock documentation update#283
Conversation
- Add Quick Start section to aws-bedrock.md for running a full Bedrock instance - Document bedrock/ prefix requirement for embedding models vs no prefix for generation - Add installation instructions for the [aws] extra (boto3, botocore) - Fix Docker Compose instructions to use --profile aws instead of DOCKER_TARGET - Fix region env var references (REGION_NAME + AWS_REGION_NAME) - Add latest Anthropic Claude models (Opus 4.6, Sonnet 4.6, Opus 4.1, Sonnet 4, etc.) - Add additional embedding models (Titan multimodal, Cohere Embed v4) - Fix default GENERATION_MODEL in llm-providers.md to match config.py - Add hybrid config examples (Bedrock embeddings + OpenAI generation and vice versa) - Add troubleshooting entries for missing AWS dependencies - Cross-reference between aws-bedrock.md and llm-providers.md
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Review completed. The documentation updates are comprehensive and well-structured, providing clear guidance for AWS Bedrock users. The Quick Start section, model tables, and troubleshooting additions are valuable improvements.
🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.
The module docstring was using the removed create_tool_calling_agent and AgentExecutor API from LangChain < v0.2. Updated to use create_agent from langchain.agents, which is the current API.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b820f2c28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates the project’s documentation to more comprehensively describe AWS Bedrock support (installation, configuration, model IDs, and Docker workflows) and to align the provider guide with the current Bedrock setup.
Changes:
- Expanded AWS Bedrock documentation with a Quick Start, region variable explanations, prefix requirements, and updated model lists.
- Refreshed
llm-providers.mdBedrock guidance (install extras, updated defaults table, expanded troubleshooting, updated Docker Compose usage). - Added cross-references between Bedrock docs and the provider overview.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| docs/llm-providers.md | Updates provider quick start and Bedrock section (extras install, model IDs, prefix guidance, Docker profile usage, defaults table). |
| docs/aws-bedrock.md | Replaces prior “consolidated” stub with a full Bedrock guide (Quick Start, region/prefix explanation, models, Docker, troubleshooting). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishal-bala
left a comment
There was a problem hiding this comment.
Just a few comments, but aside from them this LGTM 👍
- Fix REGION_NAME vs AWS_REGION_NAME: clarify AWS_REGION_NAME is required (LiteLLM), REGION_NAME is optional (server-side boto3 model-existence checks) - Fix IAM role section: note that server boto3 utilities currently require explicit credentials, but LiteLLM handles IAM roles natively - Fix REDISVL_VECTOR_DIMENSIONS description: it is a fallback/override, not auto-detected - Add asterisk notes on embedding models not in MODEL_CONFIGS (titan-embed-image, cohere.embed-v4) requiring explicit REDISVL_VECTOR_DIMENSIONS
- Clarify bedrock/ prefix is optional (not prohibited) for generation models - Remove boto3/botocore version ranges from docs - Rename LLM Proxy to LLM Proxy (LiteLLM) in architecture diagram - Update wording from 'no prefix needed' to 'prefix optional'
Summary
Updates
docs/aws-bedrock.mdanddocs/llm-providers.mdto comprehensively cover the AWS Bedrock implementation.Changes
docs/aws-bedrock.mdbedrock/prefix requirement (required for embedding models, not needed for generation models)REGION_NAMEandAWS_REGION_NAMEmust be set--profile awsinstead of the incorrectDOCKER_TARGETvariablebedrock/prefix on embedding modelsuv sync --extra awsand explicit warning about missing depsdocs/llm-providers.mdREDISVL_VECTOR_DIMENSIONS, and prefix explanation[aws]extra installation requirementGENERATION_MODELfromgpt-4o-minitogpt-5(matchingconfig.py)FAST_MODELdefault and addedSLOW_MODELrow to the reference tableMODEL_CONFIGS--profile awsaws-bedrock.mdin See Also sectionNote
Low Risk
Documentation-only changes plus a small LangChain integration example update; no runtime behavior changes to the server or client libraries.
Overview
Significantly expands AWS Bedrock documentation with a full quick start, clearer guidance on required dependencies (
agent-memory-server[aws]/uv sync --extra aws), correct Docker Compose usage (--profile aws), and explicit configuration forAWS_REGION_NAMEvsREGION_NAMEandREDISVL_VECTOR_DIMENSIONS.Clarifies LiteLLM Bedrock model naming rules (embedding models require
bedrock/, generation models don’t), refreshes the listed supported Bedrock models (including newer Claude and additional embedding options), adds hybrid configuration examples, and updates troubleshooting/migration notes. Also updates theagent_memory_clientLangChain integration docstring example to usecreate_agentand the newermessages-based invocation style.Reviewed by Cursor Bugbot for commit 51b0264. Bugbot is set up for automated code reviews on this repo. Configure here.