Add file extensions to all import statements#1277
Closed
remcohaszing wants to merge 1 commit into
Closed
Conversation
This is literally a regex replace done in VSCode, with some minor fixes for directory imports. On its own this change is not very useful. This is a preparation for ESM. ESM imports require file extensions in Node.js. The goal of this change is to prevent all the noise this causes when the actual more meaningful changes are made. I chose to use `.ts` extensions and `rewriteRelativeImportExtensions` to align with redhat-developer#1257.
Contributor
|
It seems ts-node doesn't like the .ts file extensions, and it tries to use node's type striping to load the files instead of ts-node. |
Contributor
Author
|
Yes, this did not work out the way I had hoped. I provided a couple more pull requests to to work towards this goal that do pass CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is literally a regex replace done in VSCode, with some minor fixes for directory imports.
On its own this change is not very useful. This is a preparation for ESM. ESM imports require file extensions in Node.js. The goal of this change is to prevent all the noise this causes when the actual more meaningful changes are made.
What issues does this PR fix or reference?
I chose to use
.tsextensions andrewriteRelativeImportExtensionsto align with #1257.Is it tested? How?