Skip to content

chore(app-defaults): keep app-auth at 0.0.x for now#3500

Open
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:app-defaults/keep-app-auth-at-0.0
Open

chore(app-defaults): keep app-auth at 0.0.x for now#3500
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:app-defaults/keep-app-auth-at-0.0

Conversation

@christoph-jerolimov

@christoph-jerolimov christoph-jerolimov commented Jun 19, 2026

Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

opinated: app-auth iss 0.0.3, make a flag should be fine to go to 0.0.4 for now.

We can use 0.0.x until we like to bump it because we get closer to a release

Rel to #3452

Releases

@red-hat-developer-hub/backstage-plugin-app-auth@0.1.0

Minor Changes

  • d7f7899: Make signInPage config optional and derive signInPage cards from configs defined under auth.providers

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@christoph-jerolimov christoph-jerolimov requested review from a team and rohitkrai03 as code owners June 19, 2026 20:57
@christoph-jerolimov christoph-jerolimov changed the title chore(app-defaults): keep app-auth at 0.0 for now chore(app-defaults): keep app-auth at 0.0.x for now Jun 19, 2026
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • /home/runner/work/rhdh-plugins/rhdh-plugins/workspaces/app-defaults/.changeset/tough-carpets-smell.md: @red-hat-developer-hub/backstage-plugin-app-auth

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Downgrade app-auth changeset from minor to patch (stay on 0.0.x)
⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

Description

• Change app-auth release bump from minor to patch to remain on 0.0.x
• Preserve existing changeset note about optional signInPage config and derived cards
High-Level Assessment

Keeping this as a patch bump is the most appropriate approach if the intent is to stay within 0.0.x while iterating toward release. Alternatives (removing the changeset or keeping a minor bump) don’t better match the stated versioning intent.

Files changed (1) +1 / -1

Other (1) +1 / -1
tough-carpets-smell.mdChange app-auth bump level from minor to patch +1/-1

Change app-auth bump level from minor to patch

• Updates the changeset to release '@red-hat-developer-hub/backstage-plugin-app-auth' as a patch instead of a minor bump, keeping it within the 0.0.x series. The descriptive text of the changeset remains unchanged.

workspaces/app-defaults/.changeset/tough-carpets-smell.md

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.61%. Comparing base (578c694) to head (d885297).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3500   +/-   ##
=======================================
  Coverage   53.61%   53.61%           
=======================================
  Files        2254     2254           
  Lines       85821    85821           
  Branches    24179    24177    -2     
=======================================
  Hits        46014    46014           
  Misses      38330    38330           
  Partials     1477     1477           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from 578c694
ai-integrations 67.95% <ø> (ø) Carriedforward from 578c694
app-defaults 69.79% <ø> (ø)
augment 46.39% <ø> (ø) Carriedforward from 578c694
boost 100.00% <ø> (ø) Carriedforward from 578c694
bulk-import 72.46% <ø> (ø) Carriedforward from 578c694
cost-management 14.10% <ø> (ø) Carriedforward from 578c694
dcm 61.79% <ø> (ø) Carriedforward from 578c694
extensions 61.53% <ø> (ø) Carriedforward from 578c694
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 578c694
global-header 59.71% <ø> (ø) Carriedforward from 578c694
homepage 49.92% <ø> (ø) Carriedforward from 578c694
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 578c694
konflux 91.49% <ø> (ø) Carriedforward from 578c694
lightspeed 68.57% <ø> (ø) Carriedforward from 578c694
mcp-integrations 85.46% <ø> (ø) Carriedforward from 578c694
orchestrator 37.75% <ø> (ø) Carriedforward from 578c694
quickstart 63.76% <ø> (ø) Carriedforward from 578c694
sandbox 79.56% <ø> (ø) Carriedforward from 578c694
scorecard 83.96% <ø> (ø) Carriedforward from 578c694
theme 61.26% <ø> (ø) Carriedforward from 578c694
translations 6.55% <ø> (ø) Carriedforward from 578c694
x2a 78.68% <ø> (ø) Carriedforward from 578c694

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578c694...d885297. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Semver bump misclassified 🐞 Bug ⚙ Maintainability
Description
The changeset downgrades the release type for @red-hat-developer-hub/backstage-plugin-app-auth from
minor to patch even though the changeset description corresponds to a behavior-affecting change
(deriving sign-in providers from auth.providers when signInPage is unset). Publishing that as a
patch (0.0.4 from 0.0.3) can violate semver expectations and makes the change eligible for automatic
patch upgrades (e.g., ^0.0.3).
Code

workspaces/app-defaults/.changeset/tough-carpets-smell.md[2]

+'@red-hat-developer-hub/backstage-plugin-app-auth': patch
Relevance

⭐⭐⭐ High

Team often changes changeset bump level when reviewers flag misclassification (patch↔minor).

PR-#2609
PR-#2356
PR-#2487

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The PR changes the changeset entry to patch while the changeset description and current
implementation indicate a behavior change: when signInPage is undefined, the plugin derives
provider ids from auth.providers keys. Since the package is currently versioned at 0.0.3,
classifying this as a patch will publish it as 0.0.4 (patch-level), which is inconsistent with a
behavior-affecting change.

workspaces/app-defaults/.changeset/tough-carpets-smell.md[1-5]
workspaces/app-defaults/plugins/app-auth/package.json[1-6]
workspaces/app-defaults/plugins/app-auth/src/components/SignInPage.tsx[214-225]
workspaces/app-defaults/plugins/app-auth/config.d.ts[17-24]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The changeset for `@red-hat-developer-hub/backstage-plugin-app-auth` was changed from `minor` to `patch`, but the described change is behavior-affecting (provider list defaulting from `auth.providers` when `signInPage` is not configured). This should be versioned consistently with the repo’s semver expectations.

## Issue Context
- Current package version is `0.0.3`; a `patch` changeset will produce `0.0.4`.
- The implemented behavior derives provider ids from `auth.providers` when `signInPage` is undefined, which can change which sign-in buttons appear by default.

## Fix Focus Areas
- workspaces/app-defaults/.changeset/tough-carpets-smell.md[1-5]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation Other labels Jun 19, 2026

@JessicaJHee JessicaJHee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm Other workspace/app-defaults

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants