Repository navigation
feat(prepare-sources): implement plugin-removal module (RHIDP-15835) - #174
Open
davidfestal wants to merge 2 commits into
Open
davidfestal wants to merge 2 commits into
davidfestal wants to merge 2 commits into
Conversation
davidfestal
force-pushed
the
fix-15835
branch
from
September 30, 2026 16:56
d5dd7f4 to
bcbab9a
Compare
Generate manifest.json (workspace package inventory) and, when the workspace contains backstage:^ dependencies, backstage-manifest.json with @backstage package metadata extracted from yarn.lock and validated against versions.backstage.io. Add a zero-dependency Yarn Berry lockfile parser/serializer for round-trip fidelity, shared manifest types, and fixture-based tests. Extend test utilities with a mockFetch helper and wire the module into the pipeline runner. Add @vitest/coverage-v8 and ignore the coverage directory. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com>
Intersect `plugins-list.yaml` with `rhdh-supported-packages.txt` for the current workspace, preserve packages referenced by `dist-dynamic/embedded/*/package.json`, remove infrastructure directories (`packages/app`, `packages/backend`, `.storybook`, `examples/`, `node_modules`), and delete remaining non-supported plugin directories. Rewrite the filtered `plugins-list.yaml` back to the overlay path, preserving full lines including export CLI args. Expose `overlayRepoRoot` on `PipelineInputs` so tier-list files can be read from the overlay repository root instead of resolving `../..` inside the module. Update the fixture loader to support an `input/overlay-root/` directory for tier-list fixtures. Add the module implementation, unit tests, fixtures, and README.md; wire the module into the pipeline runner. Assisted-by: Cursor Signed-off-by: David Festal <dfestal@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: David Festal <dfestal@redhat.com>
|
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin-removalpipeline moduleImplements the
plugin-removalstep of the source-preparation pipeline (RHIDP-15835).What it does:
plugins-list.yamlwithrhdh-supported-packages.txtto keep only supported pluginsdist-dynamic/embedded/*/package.json)packages/app,packages/backend,examples/,.storybook,node_modules)plugins-list.yamlpreserving comments, blank lines, and CLI argsPipeline changes:
overlayRepoRoottoPipelineInputs(needed to read tier-list files from the overlay repo root)input/overlay-root/support for tier-list test scenariosTests: 5 fixture tests + 8 unit tests, 100% coverage (statements, branches, functions, lines).
NOTE: Based on top of PR #166 which should be merged first