Repository navigation
Conversation
Cache rhdh-cli via npm pack under .yarn/cache and add a file: devDependency so hermetic Konflux builds can export plugins offline. Version comes from overlays versions.json (walk up from overlay path). Fixes RHIDP-15841 Co-authored-by: Cursor <cursoragent@cursor.com>
jonkoops
force-pushed
the
RHIDP-15841-inject-build-tools
branch
from
September 30, 2026 09:51
2f058b1 to
08348ed
Compare
jonkoops
self-requested a review
September 30, 2026 09:51
CI required full coverage; add injectable exec + unit tests for the default npm pack success and failure paths (RHIDP-15841). Co-authored-by: Cursor <cursoragent@cursor.com>
Satisfy Sonar typescript:S2871 (reliability rating) on inject-build-tools. Co-authored-by: Cursor <cursoragent@cursor.com>
When the CLI/action runs from prepare-sources/, local npm applied that package's devEngines and failed packing @red-hat-developer-hub/cli. Execute npm pack with cwd=destDir so only the pack-destination matters. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inject-build-toolspipeline module (Better Release message #9): cache@red-hat-developer-hub/cliunder.yarn/cache/and add afile:devDependencyso hermetic Konflux builds can run offline exports.cliPackage) by walking up from the overlay path to overlaysversions.json.file:.yarn/cache/…path (adapted from midstreamoffline-rhdh-cli.shmulti-workspace layout).Fixes RHIDP-15841
Test plan
vp checkinprepare-sources/vp test lib/modules/inject-build-tools/index.test.ts(24 tests)vp testsuite (86 passing)Made with Cursor