fix(design): honor interruption of queued feedback - #174
Merged
Conversation
filipeforattini
enabled auto-merge (squash)
September 8, 2026 14:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued browser feedback could resume an interrupted TUI session because the listener decoded an already decoded live event as wire data and rejected its DateTime value. Validate the event type so interrupted turns invalidate pending feedback.
The regression now seeds a real conversation and provider configuration before queuing feedback, preventing a slow cold start from hiding the failure. It fails against the previous implementation and passes with the fix; three full Design-suite repetitions passed (12 tests).
Change the existing Design changeset to minor for the maintainer-requested 0.23.0 release. Release versions remain generated by the Version PR.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.