fix(ci): give release-plz the ALSA dev package that git_only now needs - #47
Merged
Merged
Conversation
Enabling git_only in #46 got release-plz reading versions from git tags — the log now says `Latest release of package dit: tag v0.3.1` instead of silently skipping the package — but it then failed at `failed to determine next versions: run cargo package`. git_only compares the working tree against the tagged release via `cargo package`, which verifies by *building*. alsa-sys's build script panics without libasound, and this job is the only one that never installed it: before git_only it never compiled anything. ci.yml and release.yml both already do. Upstream has an open issue for the underlying brittleness (release-plz #2789, "fall back to source dir comparison when cargo package fails"); installing the dep sidesteps it rather than waiting on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46. That PR worked — the run log went from silently skipping the package to:
so
git_onlyis reading versions from git tags as intended. But it then failed:Cause
git_onlycompares the working tree against the tagged release usingcargo package, andcargo packageverifies by building. That pulls inalsa-sys, whose build script panics without libasound.release-plz.ymlis the one job that never installed it — beforegit_onlyit never compiled anything, it just read metadata.ci.ymlandrelease.ymlboth already installlibasound2-dev pkg-config.Note
This is a loud failure, not the silent-green idling from #46 — the workflow went red and stayed red. The
Flag a silent no-opguard correctly did not fire, since it only speaks when release-plz succeeds while proposing nothing.Upstream tracks the underlying brittleness in release-plz #2789 ("fall back to source dir comparison when cargo package fails"). Installing the dep sidesteps it rather than waiting on it.
Verification
Same as #46: config-only, so the proof is the next run on
main. Merging this should produce achore: release v0.3.2release PR. I will report what actually happens rather than assume.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.