perf: speed up graph parent generation and idempotent checks via size pre-filtering#154
Open
sowndappan5 wants to merge 1 commit into
Open
perf: speed up graph parent generation and idempotent checks via size pre-filtering#154sowndappan5 wants to merge 1 commit into
sowndappan5 wants to merge 1 commit into
Conversation
Add quick integer comparisons of node count (len) and edge count (number_of_edges) before calling `is_isomorphic`. This skips unnecessary isomorphic matching overhead on different-sized graphs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During GFlowNet trajectory generation and idempotent action checks, the environment frequently computes parent states and checks them for duplicate/isomorphic configurations. Even though NetworkX's
is_isomorphichas internal fast-rejection checks, calling it directly incurs Python function call and argument parsing overhead.Solution
This PR introduces a fast size-based pre-filter in:
parents()ingraph_building_env.pyget_idempotent_actions()intrajectory_balance.pyBy comparing cached integer counts of nodes and edges (
len(g)andg.number_of_edges()), we fast-reject candidate parent graphs of different sizes with zero signature-creation overhead.Evaluation & Results
Verification
All
pytestunit tests pass successfully.