Skip to content

Tv landscape rotation#2515

Open
onurcvnoglu wants to merge 2 commits intorecloudstream:masterfrom
onurcvnoglu:tv-landscape-rotation
Open

Tv landscape rotation#2515
onurcvnoglu wants to merge 2 commits intorecloudstream:masterfrom
onurcvnoglu:tv-landscape-rotation

Conversation

@onurcvnoglu
Copy link
Contributor

On TV, videos that are meant to be watched in portrait mode (such as short series) were previously rotating automatically in the player. Instead of that behavior, a manual rotate button has now been added.

Ensure the rotate control remains visible on TV/emulator layouts by relying only on `playerRotateEnabled`, instead of forcibly hiding it.
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the spacing in the entire xml makes it hard to review. Please only commit a small diff.

@@ -1,33 +1,33 @@
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change files that are not relevant to this pull request. Especially for a small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments