Skip to content

Support single line comments of the form // comment #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenglou merged 2 commits into from
Nov 13, 2018
Merged

Support single line comments of the form // comment #2254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0199ea6
Add support for single line comments of the form //
IwanKaramazow Nov 1, 2018
ffeb8ad
Fix edge case where // inside a sequence wrapped in braces didn't break.
IwanKaramazow Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion formatTest/unit_tests/expected_output/basicStructures.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ let x = arr^[0] = 1;
*============================================================================
*/;

let (/\/) = (+); /* // is not a comment */
let (/++) = (+); /* // indicates the start of a comment, not an infix op */

let something =
if (self.ext.logSuccess) {
Expand Down
1 change: 1 addition & 0 deletions formatTest/unit_tests/expected_output/emptyFileComment.re
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// file with just a single line comment
Loading