fix(mdxish): extend mdx tokenizer to fix commonmark splitting HTML issue#1533
Open
eaglethrost wants to merge 2 commits into
Conversation
…-style-blocks-and' into dimas/cx-3646-dont-reuse-preprocessor
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
PR #1532 to address CX-3646 creates a preprocessing step protect-nested-html-blank-lines.ts to address the issue of HTML tags getting fragmented when there's empty spaces inside (due to CommonMark rules).
This PR attempts to fix the same issue without the preprocessing by piggy backing & extending the MDX tokenizer to also capture HTML sequences without brace attributes, which would capture the sequence that has the problematic empty lines in it. The state would be marked as
isPlainBlockClaim. It would prevent another preprocessing steps which is flaky and more difficult to maintain.🧪 QA tips
The same tests should pass and the CX-3646 doc should still render