fix: correct exports map ordering#1529
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
WalkthroughThis change adds TypeScript type re-exports for MdxishOpts, RenderMdxishOpts, and RunOpts in index.tsx and RunOpts in lib/index.ts, extending the module's public API surface. Additionally, package.json's exports["."] condition map was updated to list the node condition before the browser condition, reversing their previous order. Changes
Related PRs: None identified. Suggested labels: types, dependencies Suggested reviewers: None identified. Poem Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: read ECONNRESET Comment |
## Version 14.11.0 ### ✨ New & Improved * **mdxish:** replace brace-escaping preprocessing with lenient expression tokenizer ([#1531](#1531)) ([5c5a57c](5c5a57c)) * **mdxish:** support library imports in declarations ([#1530](#1530)) ([fa6ee97](fa6ee97)) ### 🛠 Fixes & Updates * correct exports map ordering ([#1529](#1529)) ([08a63dd](08a63dd)) <!--SKIP CI-->
This PR was released!🚀 Changes included in v14.11.0 |

Context
In Add render-diff and render-fixture subpath exports + MDX↔MDXish regression suite #1489 we added an exports map to support new regression test exports
markdown/package.json
Lines 9 to 26 in 928b36e
But the map listed "browser" first. Some tools (like Jest, when testing React components) ask for both "browser" and "node" at once so Jest kept receiving the browser file when it needs the node file.
This caused these test failures in the monorepo https://github.com/readmeio/readme/actions/runs/28407377427/job/84174978249?pr=19434
We added this fix which forces jest to use the node file. But a simpler fix is to just re-order the entries in the @readme/markdown package
🎯 What does this PR do?
🧪 QA tips
📸 Screenshot or Loom