fix(mdxish): terminate html flow block when opener has trailing text#1495
Open
maximilianfalco wants to merge 1 commit into
Open
Conversation
993085e to
13742c1
Compare
13742c1 to
993085e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
Magic blocks placed directly under an opening HTML tag with trailing text were rendering as literal text because CommonMark consumed them into the HTML flow block. The
terminateHtmlFlowBlockspreprocessor only recognized lines that were purely tags or had a matched open+close pair, so<li>test slipped pastisLineHtmland no blank-line terminator was inserted.Adds a third regex (
HTML_LINE_WITH_TRAILING_CONTENT_REGEX) for lines that start with a lowercase HTML tag followed by trailing text🧪 QA tips
verify that the table renders as expected
📸 Screenshot or Loom
monorepo showcase
