fix(mdxish): render footnote refs in table#1494
Open
maximilianfalco wants to merge 3 commits into
Open
Conversation
005ad5e to
2843a71
Compare
2843a71 to
005ad5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
[^1]inside<Table>/<table>cells rendered as literal text and produced no footnote section.mdxishTablesre-parses each table block through an isolated processor, andremark-gfmonly tokenizes a footnote reference when the matching definition lives in the same parse context, so cell text stayed literal, and with no references emitted the outer document's definition was orphaned andremark-rehypedropped the<section>.The fix collects every footnote id from the outer tree once and primes the table and cell re-parses with synthetic
[^id]: xplaceholders so refs tokenize correctly; the synthetic definitions are then stripped from the cell scope so only the real outer-document definition reaches the renderer.🧪 QA tips
Verify that both tables render footnotes correctly
📸 Screenshot or Loom
verified it works in the monorepo as well
