Release/1.0.4

[apatel859]

No description provided.

[Copilot]

Pull request overview

This PR prepares the Release/1.0.4 cut by introducing a full L1 (unit-level) test harness, expanding platform/service APIs (manufacturer/model propagation), and updating the build system to support both libsoup 2.4 and libsoup 3.0 paths (plus CI workflows).

Changes:

• Add an autotools-based L1 test harness (gtest/gmock) with extensive server/plat/util coverage and CI workflow execution (including valgrind + coverage artifacts).
• Add libsoup 2.4 vs 3.0 source splits and detection in CMake/autotools, plus new stub/mocks and build scripts for native CI.
• Introduce manufacturer/model update plumbing across service → plat → ssdp, and add UUID-based app URIs used by the local REST additional-data endpoint.

Reviewed changes

Copilot reviewed 60 out of 61 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
tests/README.md	Documents the new L1 test harness layout, workflow, and pitfalls.
tests/Makefile.am	Adds autotools test subdir build gating via ENABLE_L1TESTS.
tests/L1Tests/Makefile.am	Defines the run_L1Tests binary sources, flags, and soup/gssdp conditionals.
tests/L1Tests/test_main.cpp	Adds unified gtest/gmock main for the L1 runner.
tests/L1Tests/utils/test_gdialUtil.cpp	Adds unit tests for gdial-util hashtable helpers and ASCII checks.
tests/L1Tests/tests/gdialserver_ut.cpp	Adds a placeholder test file under tests/ (currently not built).
tests/L1Tests/stubs/gdial_cpp_test_stubs.hpp	Provides lightweight C++ stubs for WPEFramework/security token APIs in tests.
tests/L1Tests/mocks/gssdp_mock.c	Adds minimal GSSDP mocks to decouple tests from network/GSSDP runtime behavior.
tests/L1Tests/server/test_gdialSsdp.cpp	Adds SSDP tests (dd.xml callback + setter coverage).
tests/L1Tests/server/test_gdialShield.cpp	Adds shield tests around SoupServer request throttling/timeout paths.
tests/L1Tests/server/test_gdialService.cpp	Adds service-layer tests (impl singleton, request routing, conditional startup).
tests/L1Tests/server/test_gdialServer.cpp	Adds tests for GDialApp lifecycle and helper coverage.
tests/L1Tests/server/test_gdialserver_ut.cpp	Adds tests for the interactive gdialserver UT main loop using a fake service.
tests/L1Tests/server/test_gdialRest.cpp	Adds REST server tests (register/unregister, origin checks, launch flows, additional data).
tests/L1Tests/plat/test_gdialPlat.cpp	Adds tests for GDialAppRegistry construction and origin allow-list behavior.
tests/L1Tests/plat/test_gdialAppCache.cpp	Adds tests for GDialAppStatusCache set/get behavior and isolation.
tests/L1Tests/plat/test_gdialPlatApp.cpp	Adds platform app API guard/lifecycle/async tests.
tests/L1Tests/plat/test_gdialPlatDev.cpp	Adds tests for plat-dev power/network standby callbacks.
tests/L1Tests/plat/test_gdialPlatUtil.cpp	Adds tests for iface IP/MAC helpers and logging behavior.
tests/L1Tests/plat/gdial_os_stubs.cpp	Adds OS-layer stubs and controllable behavior for plat-app tests.
stubs/securityagent/SecurityTokenUtil.h	Adds a stub header for SecurityAgent token access.
stubs/securityagent/SecurityTokenUtil.cpp	Adds a stub implementation for GetSecurityToken.
stubs/iarm_stubs.cpp	Adds IARM stub implementations for native CI builds.
server/plat/gdialappcache.hpp	Initializes observer pointer to null to avoid uninitialized usage.
server/plat/gdialappcache.cpp	Improves safety/logging and moves strings to avoid copies.
server/plat/gdial.hpp	Adds manufacturer/model callback typedefs + registration APIs.
server/plat/gdial-plat-util.c	Fixes thread-id formatting in logging and annotates coverity intent.
server/plat/gdial-plat-dev.c	Removes env-based manufacturer/model getters.
server/plat/gdial-plat-app.c	Adds manufacturer/model update APIs + callback registration glue.
server/plat/gdial-os-app.h	Adds OS hooks for manufacturer/model updates.
server/plat/gdial_app_registry.c	Adds UUID generation/persistence and app_uri initialization.
server/plat/CMakeLists.txt	Adds DISABLE_SECURITY_TOKEN option and links uuid.
server/libsoup/2.4/gdial-rest.c	Updates additionalDataUrl construction + UUID routing; various fixes/annotations.
server/libsoup/2.4/gdial-ssdp.c	Adds mutex sync + manufacturer/model override support.
server/libsoup/2.4/gdial-shield.c	Adds/ports shield module implementation for libsoup 2.4 tree.
server/libsoup/3.0/gdial-rest.c	libsoup 3.0-compatible REST implementation (UUID routing + fixes/annotations).
server/libsoup/3.0/gdial-ssdp.c	libsoup 3.0-compatible SSDP implementation (mutex + manufacturer/model).
server/libsoup/3.0/gdial-shield.c	libsoup 3.0-compatible shield implementation.
server/include/gdialserviceimpl.h	Adds new request events/payload fields; initializes observer pointer.
server/include/gdialservicecommon.h	Removes onStopped() from notifier interface.
server/include/gdialservice.h	Adds manufacturer/model setter APIs; minor header cleanup.
server/include/gdial-plat-dev.h	Removes manufacturer/model getter declarations.
server/include/gdial-plat-app.h	Adds manufacturer/model callback typedefs + update APIs.
server/include/gdial-config.h	Renames include guard and removes unused enum.
server/include/gdial_app_registry.h	Adds app_uri field and uuid size macro to registry struct.
server/gdialservice.cpp	Wires manufacturer/model callbacks to SSDP, adds libsoup3 handling, refactors payload init/moves.
server/gdialserver_ut.cpp	Adjusts test utility to match notifier interface changes and fixes moves.
server/gdial-ssdp.h	Exposes manufacturer/model setters.
server/gdial-rest.h	Updates additionalDataUrl signature and adds find-by-uuid API.
server/CMakeLists.txt	Adds libsoup3 detection, selects correct source set (2.4 vs 3.0).
Makefile.am	Adds autotools to build tests subdir.
Makefile	Passes DISABLE_SECURITY_TOKEN cmake option through build.
configure.ac	Adds autotools project definition + optional L1 test enablement and soup/gssdp probing.
cov_build.sh	Adds a small build script for coverage/native CI.
CHANGELOG.md	Adds/updates changelog entries for releases up to 1.0.4.
build_dependencies.sh	Adds native CI dependency install + building required third-party components/stubs.
.github/workflows/native_full_build.yml	Adds native container build workflow.
.github/workflows/L1-tests.yml	Adds CI workflow for L1 tests, valgrind, and coverage artifacts.
.github/CODEOWNERS	Adds repo ownership rules.

Comments suppressed due to low confidence (6)

server/libsoup/2.4/gdial-ssdp.c:264

• Same issue as libsoup/3.0: handler is added at "/<random_uuid>/dd.xml" but destroy removes only "/dd.xml" (leaving the handler installed).
  server/libsoup/2.4/gdial-rest.c:24
• gdial-rest logs pthread_self() but doesn't include <pthread.h>, which can fail compilation with -Werror due to implicit declaration of pthread_self().
  server/libsoup/2.4/gdial-ssdp.c:320
• gdial_ssdp_destroy() doesn't free the process-global strings app_friendly_name/app_manufacturer_name/app_model_name, so values can persist across init/destroy and leak memory (valgrind will flag this).
  server/libsoup/2.4/gdial-rest.c:548
• Avoid tool-specific comments like "FIX(Copilot)" in source; the intent here is just to avoid accidental use-after-free if this block is edited later.
  server/libsoup/2.4/gdial-rest.c:663
• Avoid tool-specific comments like "FIX(Copilot)" in source; the intent here is just to destroy the duplicated query table after merging.
  server/include/gdial_app_registry.h:45
• GDialAppRegistry is defined as a public struct in an installed header; adding app_uri changes the struct layout and can break ABI for any external consumers. Consider making GDialAppRegistry opaque and exposing accessors, or keep UUID/URI internal to the server side.

typedef struct _GDialAppRegistry {
  gchar app_uri[APP_MAX_UUID_SIZE+1]; // for storing uri
  gchar *name;
  gboolean use_additional_data;
  gboolean is_singleton;
  GList *allowed_origins;
  GList *app_prefixes;
  GHashTable *properties;
} GDialAppRegistry;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.