RDKCOM-1035:dnsmasq: reduce EDNS packet size to 1232 - #395
Open
tinaelizabeth84 wants to merge 1 commit into
Open
RDKCOM-1035:dnsmasq: reduce EDNS packet size to 1232#395tinaelizabeth84 wants to merge 1 commit into
tinaelizabeth84 wants to merge 1 commit into
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dnsmasq startup command to reduce the EDNS(0) maximum UDP packet size, aiming to limit fragmentation issues by lowering the -P value.
Changes:
- Changed dnsmasq EDNS packet size limit from
4096to1232for multiple dnsmasq start command variants in the DHCP/DNS service script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+129
to
+131
| $SERVER -q --clear-on-reload --bind-dynamic --add-mac --add-cpe-id=abcdefgh -P 1232 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION --proxy-dnssec --cache-size=0 --xdns-refac-code #--enable-dbus | ||
| else | ||
| $SERVER -q --clear-on-reload --bind-dynamic --add-mac --add-cpe-id=abcdefgh -P 4096 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION --proxy-dnssec --cache-size=0 --stop-dns-rebind --log-facility=/rdklogs/logs/dnsmasq.log #--enable-dbus | ||
| $SERVER -q --clear-on-reload --bind-dynamic --add-mac --add-cpe-id=abcdefgh -P 1232 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION --proxy-dnssec --cache-size=0 --stop-dns-rebind --log-facility=/rdklogs/logs/dnsmasq.log #--enable-dbus |
| fi | ||
| else | ||
| $SERVER -P 4096 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION #--enable-dbus | ||
| $SERVER -P 1232 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION #--enable-dbus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test commit do not merge