RDKEMW-22728 : [support/8.4.4.0] [SECVULN][7.5] Remove sensitive information from property files in /etc - #593
Merged
Conversation
…rmation from property files in /etc
Contributor
There was a problem hiding this comment.
Pull request overview
Removes hardcoded sensitive/config-specific values from /etc property files to reduce exposure of internal endpoints and credentials in shipped images.
Changes:
- Removed crash dump server IP and upload credentials from
etc/config.properties. - Removed multiple internal IP endpoints (crash/proxy/CDL/image/TFTP) from
etc/common.properties.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| etc/config.properties | Removes crash dump server IP and dump upload user/password values. |
| etc/common.properties | Removes internal endpoint IPs for crash/proxy/CDL/image/TFTP settings. |
Comments suppressed due to low confidence (1)
etc/config.properties:28
POTOMAC_SVRstill embeds a concrete server IP in/etc/config.properties. To fully remove sensitive infrastructure details from/etc, replace this with an empty value or a placeholder hostname (similar toetc/dcm.propertiesusing*.example.com).
POTOMAC_SVR=69.252.107.55
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.