RDKEMW-22728 : [support/8.4.4.0] [SECVULN][7.5] Remove sensitive information from property files in /etc - #589
Merged
Merged
Conversation
…rmation from property files in /etc
Contributor
There was a problem hiding this comment.
Pull request overview
Removes hard-coded sensitive endpoints/credentials from /etc property files to address a security vulnerability and reduce leakage of internal configuration via shipped defaults.
Changes:
- Removed crash upload server address and dump upload usernames/passwords from
etc/config.properties. - Removed several hard-coded infrastructure endpoints (proxy/CDL/image/TFTP) from
etc/common.properties.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
etc/config.properties |
Removes hard-coded crash upload server and dump upload credentials from /etc configuration. |
etc/common.properties |
Removes hard-coded proxy/CDL/image/TFTP endpoints from shared /etc configuration. |
Comments suppressed due to low confidence (1)
etc/config.properties:28
- PR title indicates removing sensitive information from /etc property files, but
POTOMAC_SVRis still a hard-coded external IP in this file. If the intent is to avoid leaking internal/external endpoints, consider blanking this and sourcing it from a secure/override mechanism.
POTOMAC_SVR=69.252.107.55
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.