RDKB-63950 : update aker.service to support chronyd - #128
Open
sindhu-krishnan wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates aker.service to wait for NTP time synchronization using the sysevent ntp_time_sync flag (instead of ntpd-status), enabling the service to start promptly after sync regardless of the underlying NTP client (e.g., chronyd).
Changes:
- Switch pre-start wait condition from
sysevent get ntpd-status == startedtosysevent get ntp_time_sync == 1.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| EnvironmentFile=/etc/include.properties | ||
| EnvironmentFile=/etc/device.properties | ||
| ExecStartPre=/bin/sh -c 'count=0; while true; do var=`sysevent get ntpd-status`; if [ "$var" == "started" ]; then break; fi; sleep 5; count=`expr $count + 1`; if [ "$count" == 17 ]; then echo "Max wait 85s"; break; fi; done' | ||
| ExecStartPre=/bin/sh -c 'count=0; while true; do var=`sysevent get ntp_time_sync `; if [ "$var" == "1" ]; then break; fi; sleep 5; count=`expr $count + 1`; if [ "$count" == 17 ]; then echo "Max wait 85s"; break; fi; done' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
asker.service updated to check the ntp status irrespective of ntp client
Test Procedure: aker.service should start immediately after ntp sync
Risks: Medium
Priority: P1
Signed-off-by: Sindhuja Sindhuja_Muthukrishnan@comcast.com