VPAAMP-903 deprecate monitor integrity feature - #1812
Merged
Conversation
Reason for Change: When using mp4demux, we get the equivalent of monitor integrity feature "for free." The only thing monitorIntegrity feature gets us is an mp4demux powered preprocessing sanity check that can be done along with qtdemux. Recomending to deprecate given direction to use mp4demux by default. Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates/removes the legacy “monitor integrity” feature (Mp4Demux-based segment parsing for corruption detection) on the grounds that mp4demux already provides equivalent integrity checking by default.
Changes:
- Removed the per-segment integrity monitoring path (
CheckSegmentIntegrity) and its invocation from the download pipeline. - Removed the
monitorMp4Integrityboolean config option from the bool-config enum and lookup table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
priv_aamp.cpp |
Removes the integrity-check implementation and the call site in GetFile(). |
AampConfig.h |
Removes eAAMPConfig_MonitorMp4Integrity from the boolean config enum. |
AampConfig.cpp |
Removes monitorMp4Integrity from the bool-config lookup table, making it no longer parseable from config. |
Comment on lines
5241
to
5243
| } | ||
|
|
||
| if (ISCONFIGSET_PRIV(eAAMPConfig_MonitorMp4Integrity) && | ||
| !buffer.empty() && | ||
| (mediaType == eMEDIATYPE_VIDEO || mediaType == eMEDIATYPE_INIT_VIDEO || | ||
| mediaType == eMEDIATYPE_AUDIO || mediaType == eMEDIATYPE_INIT_AUDIO)) | ||
| { | ||
| CheckSegmentIntegrity(buffer, mediaType, remoteUrl); | ||
| } | ||
|
|
||
|
|
||
| ret = true; // default |
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: When using mp4demux, we get the equivalent of monitor integrity feature "for free." The only thing monitorIntegrity feature gets us is an mp4demux powered preprocessing sanity check that can be done along with qtdemux. Recomending to deprecate given direction to use mp4demux by default.
Risk: Low
Test Guidance: confirm monitorMp4Integrity=true no longer supported