Feature/vpaamp 899 - #1809
Open
Gnanesha wants to merge 2 commits into
Open
Conversation
…on in LL‑DASH Mode leading to stall in playback Reason for change: check against floating point precision Risks: Low Test Procedure: Test with MPD streams with ads Priority: P1
…on in LL‑DASH Mode leading to stall in playback Reason for change: check against floating point precision Risks: Low Test Procedure: Test with MPD streams with ads Priority: P1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts discontinuity-handling logic in MediaTrack::CheckForDiscontinuity() by avoiding an exact floating-point comparison when checking whether any duration has been injected, and also changes the log level used when a discontinuity is detected.
Changes:
- Introduces an epsilon constant and switches the
injectedDuration == 0check tostd::fabs(injectedDuration) < EPS. - Promotes a discontinuity log from
AAMPLOG_TRACEtoAAMPLOG_INFO.
| bool stopInjection = false; | ||
| StreamAbstractionAAMP* context = GetContext(); | ||
| double injectedDuration = GetTotalInjectedDuration(); | ||
| static constexpr double EPS = 0.01; // floating point comparison tolerance. |
| { | ||
| bool isDiscoIgnoredForOtherTrack = aamp->IsDiscontinuityIgnoredForOtherTrack((AampMediaType)!type); | ||
| AAMPLOG_TRACE("track %s - encountered aamp discontinuity @position - %f, isDiscoIgnoredForOtherTrack - %d ptsError %d", name, cachedFragment->position, isDiscoIgnoredForOtherTrack,ptsError ); | ||
| AAMPLOG_INFO("track %s - encountered aamp discontinuity @position - %f, isDiscoIgnoredForOtherTrack - %d ptsError %d", name, cachedFragment->position, isDiscoIgnoredForOtherTrack,ptsError ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.