VPAAMP 293 : Audio loss occurs when switching audio tracks in multiview streams - #1774
Closed
Abhi-jith-S wants to merge 3 commits into
Closed
VPAAMP 293 : Audio loss occurs when switching audio tracks in multiview streams#1774Abhi-jith-S wants to merge 3 commits into
Abhi-jith-S wants to merge 3 commits into
Conversation
Signed-off-by: Abhi-jith-S <abhijithssa7@gmail.com>
Signed-off-by: Abhi-jith-S <abhijithssa7@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address audio loss during audio-track switches in multiview streams by detecting ISO-BMFF audio track_id mismatches across periods and overwriting the in-fragment track_id when needed. It also extends ISO-BMFF parsing to read track_id from tfhd boxes (for cases where trak may be absent in media fragments).
Changes:
- Add
MediaStreamContext::DetectMismatchAndOverwriteTrackId()and call it during audio/init-audio fragment caching. - Extend
IsoBmffBuffer::getTrack_id()to fall back totfhdtrack_idwhentrakisn’t found. - Enhance
TfhdBoxto capture and optionally overwrite thetrack_idfield during TFHD construction.
Scores: Completeness 9/10, Assumptions 8/10, Clarity 9/10, CostRisk 4/10 | Critique: Solid diff/context provided across all touched files; moderate traversal cost due to multi-module touchpoints (MediaStreamContext + ISO-BMFF box/buffer). | Improve: Add a short “Expected behavioral change” and “When mismatch is detected (init vs media fragments)” note, plus explicit test references to run/extend.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| MediaStreamContext.h | Declares new helper to detect/handle audio track_id mismatches. |
| MediaStreamContext.cpp | Implements mismatch detection and invokes it for audio fragment caching. |
| isobmff/isobmffbuffer.cpp | Adds TFHD-based fallback when extracting track_id. |
| isobmff/isobmffbox.{h,cpp} | Adds TFHD track_id storage/overwrite support in TfhdBox. |
Comment on lines
+85
to
+100
| uint32_t track_id = 0; | ||
| buffer.getTrack_id(track_id); | ||
|
|
||
| bool trackIdUpdated = false; | ||
| AAMPLOG_DEBUG("Audio track_id read from fragment: %d and track id stored in AAMP instance: %d", track_id, aamp->mCurrentAudioTrackId); | ||
| if (aamp->mCurrentAudioTrackId != -1 && track_id != aamp->mCurrentAudioTrackId) | ||
| { | ||
| buffer.parseBuffer(false, aamp->mCurrentAudioTrackId); | ||
| trackIdUpdated = true; | ||
| aamp->mIsTrackIdMismatch = true; | ||
| AAMPLOG_DEBUG("TrackId mismatch detected for audio, current track_id: %d, next period track_id: %d", aamp->mCurrentAudioTrackId, track_id); | ||
| } | ||
| if (!trackIdUpdated) | ||
| { | ||
| aamp->mCurrentAudioTrackId = track_id; | ||
| } |
| } | ||
| } | ||
|
|
||
| if ((actualType == eMEDIATYPE_INIT_AUDIO || actualType == eMEDIATYPE_AUDIO) && ret) |
Comment on lines
+514
to
+526
| else if (IS_TYPE(box->getType(), Box::TFHD)) | ||
| { | ||
| try { | ||
| TfhdBox *tfhdBox = dynamic_cast<TfhdBox *>(box); | ||
| if(tfhdBox) | ||
| { | ||
| tfhdTrackId = tfhdBox->getTrackId(); | ||
| tfhdTrackFound = true; | ||
| } | ||
| } catch (std::bad_cast& bc){ | ||
| //do nothing | ||
| } | ||
| } |
Comment on lines
+532
to
+536
| if (!ret && tfhdTrackFound) | ||
| { | ||
| track_id = tfhdTrackId; | ||
| ret = true; | ||
| } |
…nt branch Signed-off-by: Abhi-jith-S <abhijithssa7@gmail.com>
Contributor
Author
|
Closing the PR now as we are waiting for approval of fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : To overwrite track-id for audio tracks incase of mismatch
Test Procedure : Refer ticket