Fix freeTextureSource() leaving stale entries in textureSourceHashmap

[guilhermesimoes]

When gc() is called, it calls freeUnusedTextureSources, which at the end calls _cleanupLookupMap, cleaning up all unused texture sources from textureSourceHashmap.

However, when freeTextureSource is called (either when a texture source is replaced or when someone manually calls texture.free()), the stale texture source is kept inside textureSourceHashmap, leading to a memory leak.

This issue was detected because we use a single text texture for subtitles, and keep changing the text of that texture as playback progresses.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[Copilot]

Pull request overview

This PR fixes a memory leak in the texture source reuse cache by ensuring freeTextureSource() removes freed texture sources from textureSourceHashmap, matching the cleanup behavior already performed during gc().

Changes:

• Remove stale textureSourceHashmap entries when freeTextureSource() is called.
• Minor whitespace cleanup in TextureManager.mjs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[guilhermesimoes]

I have read the CLA Document and I hereby sign the CLA

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/tree/TextureManager.mjs:199

• When freeing a loaded texture source, VRAM usage is incremented in uploadTextureSource() via _updateVramUsage(textureSource, 1), but freeTextureSource() never decrements it. This can leave Stage.usedVram* stats stale (only increasing) after manual frees / source replacement.

Call _updateVramUsage(textureSource, -1) before _nativeFreeTextureSource() (it needs textureSource.nativeTexture to still be present).

            this._nativeFreeTextureSource(textureSource);
        }

        this.textureSourceHashmap.delete(textureSource.lookupId);

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/tree/TextureManager.mjs:198

• freeTextureSource() deletes from textureSourceHashmap purely by lookupId. If the same lookupId has been re-associated to a different TextureSource (e.g., after a cleanup/reload), this will remove the wrong entry. Guard against falsy ids and only delete when the map currently points to the instance being freed.

        this.textureSourceHashmap.delete(textureSource.lookupId);

src/tree/TextureManager.mjs:195

• freeTextureSource() updates _usedMemory for managed textures but does not update VRAM usage counters, unlike _freeManagedTextureSource(). This will leave Stage.usedVram* overstated when textures are freed manually or on replacement.

            if (managed) {
                this._addMemoryUsage(-textureSource.w * textureSource.h);
                this._uploadedTextureSources.splice(index, 1);
            }
            this._nativeFreeTextureSource(textureSource);

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.