-
Notifications
You must be signed in to change notification settings - Fork 14
Add conditional check for sqlpp23 alias creation #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check if target sqlpp23::sqlpp23 exists before creating alias.
|
I have a couple of questions about this PR:
|
for the first question, I used the target provided by the project (at cmake/configs/Sqlpp23Config.cmake) |
Which target did you use, was it
Again, can you provide the minimal reproducible example? Actually I cannot imagine how and why it would try to create a second alias. I'd like to examine the problem in more detail, because the proposed fix in your PR seems to be masking some other bug. |
|
I tried to reproduce the problem, that your PR tries to fix, with the connection pool example. The connection pool example needed a few minor fixes (see the other PR that I just submitted), but otherwise it worked fine. I tried modifying its CMakeLists.txt and replaced the So for me everything works correctly, just as expected. As I said before, I really want to see your minimal reproducible example, because I am unable to reproduce the error on my machine. Just for the record, I am using |
I will send a minimum example later |
Check if target sqlpp23::sqlpp23 exists before creating alias. this is important if you need to recreate the cmake target