feat: export Audit logs page as a component and consume it in apps/admin #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paanSinghCoder
changed the base branch from
main
to
feat/export-products-page
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR restructures the admin application from a container-based architecture to a page-based routing pattern. It moves utility functions (pagination, query transformation, timestamps) to a centralized Changes
Sequence Diagram(s)sequenceDiagram
participant Router as React Router
participant Page as ProductsPage
participant View as ProductsView
participant API as FrontierServiceQueries
Router->>Page: Render with :productId param
Page->>Page: useParams() → productId<br/>useNavigate() → navigate
Page->>View: Render with navigation callbacks
View->>API: useQuery(listProducts)
API-->>View: Product list data
View->>View: Build product map by ID
View->>View: Render DataTable with products
Router->>View: User clicks product row
View->>Page: onRowClick(id)
Page->>Page: navigate(`/products/${id}`)
Router->>Page: Update route, re-render
Page->>View: Pass onNavigateToPrices callback
Router->>View: User clicks "View Prices"
View->>Page: onNavigateToPrices(productId)
Page->>Page: navigate(`/products/${productId}/prices`)
Router->>Page: Route to ProductPricesPage
sequenceDiagram
participant Page as AuditLogsPage
participant View as AuditLogsView
participant Navbar as Navbar
participant Admin as AdminClient
participant Helper as exportCsvFromStream
Page->>Page: Create adminClient with binary export
Page->>Page: Define onExportCsv callback (memoized)
Page->>View: Render with onExportCsv prop
View->>Navbar: Pass onExportCsv handler
Navbar->>Navbar: Query state updated
Router->>Navbar: User clicks "Export CSV"
Navbar->>Page: Call onExportCsv(query)
Page->>Admin: adminClient.exportAuditRecords(mappedQuery)
Admin-->>Helper: Stream response
Helper->>Helper: Accumulate chunks as Blob
Helper-->>Browser: Trigger download as CSV file
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
paanSinghCoder
added
the
Do not merge
Pull Request Test Coverage Report for Build 21901112133Details
💛 - Coveralls |
paanSinghCoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
apps/admin/src/pages/audit-logs/list/tolib/admin/views/audit-logs/(usinggit mvto preserve history)AuditLogsViewfrom@raystack/frontier/adminas a router-agnostic view component with optionalappNameandonExportCsvpropsAuditLogsPagewrapper inapps/adminthat provides app-specific dependencies (CSV export via admin client).svg?reactimportsreact-router-domresolve alias invite.config.tsand as an optional peer dependency in the lib@raystack/apsarain lib to0.56.2foruseDebouncedStateandCodeBlocktype supportlocalsConvention: 'camelCase') in tsup config to preserve kebab-case class name accessTest plan
pnpm buildinweb/lib)pnpm buildinweb/apps/admin)