Add interface is_model_splitted() to check the c-graph is splited or not#63
Open
zhaixuejun1993 wants to merge 1 commit intoravi9:dev_backend_openvinofrom
Open
Conversation
| bool model_is_splitted = is_model_splitted(cgraph); | ||
|
|
||
| if (is_naive(cgraph) && !model_is_splitted) { | ||
| return naive_compute(cgraph, core, device, config); |
Collaborator
There was a problem hiding this comment.
Will this impact any of the CI tests if the model is splitted?
Collaborator
Author
There was a problem hiding this comment.
Yes, after split the sub c-graph node size maybe < 20, which will be handled as the CI test. That is not we want. This is to avoid the sub c-graph from fallback are handled by naive compute.
BTW, I had verified the test-backend-ops it PASS.
Collaborator
There was a problem hiding this comment.
Oh ok, I was thinking about the embedding test which has partitioning.
zhaixuejun1993
force-pushed
the
xuejun/add_is_model_splited
branch
from
5f3afb2 to
2fbffd4
Compare
Collaborator
|
I see a failure in MUL_MAT_VEC_FUSION test. It needs a rebase maybe? |
ggerganov
force-pushed
the
dev_backend_openvino
branch
from
76e4057 to
e73b4d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.