Fix attention size computation error in OpenVINO backend for LLM#131
Merged
wine99 merged 1 commit intoravi9:dev_backend_openvinofrom Apr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the OpenVINO GGML decoder logic, primarily improving the detection and handling of attention-related operations and key-value cache identification. The changes enhance robustness when parsing computational graphs and ensure that certain preprocessing steps are only applied in appropriate contexts.
Improvements to attention and KV cache handling:
compute_llm_paramsto check for deeper source validity when handlingGGML_OP_SOFT_MAX, preventing potential null pointer dereferences.attention_sizefrom specificGGML_OP_MUL_MATgraph patterns involving permute and view operations, increasing accuracy in parameter computation for attention mechanisms.is_kvcachestatic method to prioritize buffer usage checks, making the order of conditions more robust and consistent.Preprocessing logic improvements:
preprocessfunction to only add sliced masks when the decoder is stateful, preventing unnecessary operations for stateless models.## OverviewAdditional information
Requirements