Repository navigation
drm/vc4: hdmi: Only ignore hotplug interrupts on forced connectors - #7727
Draft
popcornmix wants to merge 1 commit into
Draft
popcornmix wants to merge 1 commit into
popcornmix wants to merge 1 commit into
Conversation
vc4.force_hotplug is a per-connector bitmask, and detect only forces the connectors whose bit is set. The hotplug interrupt handler instead ignored interrupts on every connector whenever any bit was set. As these connectors use DRM_CONNECTOR_POLL_HPD they are not polled, so e.g. force_hotplug=2 (HDMI1 only) left HDMI0 status stuck after a plug or unplug. Check the connector's own bit, matching detect. Fixes: cb7db28 ("vc4/hdmi: Ignore hotplug interrupt with force_hotplug") Link: raspberrypi#7724 Signed-off-by: Dom Cobley <popcornmix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vc4.force_hotplug is a per-connector bitmask, and detect only forces the connectors whose bit is set. The hotplug interrupt handler instead ignored interrupts on every connector whenever any bit was set.
As these connectors use DRM_CONNECTOR_POLL_HPD they are not polled, so e.g. force_hotplug=2 (HDMI1 only) left HDMI0 status stuck after a plug or unplug.
Check the connector's own bit, matching detect.
Fixes #7724