Use std::span for cudf::split/cudf::concatenate calls#1077
Open
joannamooon wants to merge 1 commit into
Open
Conversation
Signed-off-by: joannam <joannam@nvidia.com>
d71feac to
732e0ce
Compare
3 tasks
Contributor
|
Thanks for this. You weren't to know, but we're currently porting the cudf-specific parts of rapidsmpf into the cudf repo (see rapidsai/cudf#22747). If you can retarget this change on top of that once it is merged and close this one that would be great! |
Contributor
|
Whoops clicked wrong. I also mentioned this on rapidsai/cudf#22588 (comment) 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cudf is migrating its public APIs from
cudf::host_spantostd::span(rapidsai/cudf#22588). That migration changes the mangled symbols of several exported libcudf functions, two of which rapidsmpf calls:cudf::splitandcudf::concatenate. Because rapidsmpf is consumed prebuilt from nightlies, its compiled librapidsmpf.so references the old host_span symbols and fails to load against the new libcudf with:This PR updates rapidsmpf's call sites to the new signatures so it builds and links against the migrated libcudf.
Changes
All in
cpp/src/integrations/cudf/partition.cpp:cudf::split— the partition_offsets argument was an explicitcudf::host_span<cudf::size_type const>;changed tostd::span<cudf::size_type const>to match the new cudf::split signature.std::vector<cudf::table_view>) converts implicitly tostd::span, sorecompiling against the new libcudf resolves the symbol.
#include <span>.