Skip to content

Switch to building with nerdctl/buildkit on windows #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wmaxey wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Switch to building with nerdctl/buildkit on windows #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 30 additions & 22 deletions windows/build-windows-image.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
# clVersion, cudaVersion, OS edition, isolation mode
Param(
[Parameter(Mandatory=$true)]
[Parameter(Mandatory = $true)]
[string]
$clVersion="latest",
[Parameter(Mandatory=$false)]
$clVersion = "latest",
[Parameter(Mandatory = $false)]
[string]
$cudaVersion="latest",
[Parameter(Mandatory=$false)]
[ValidateSet('windows2019', 'windows2022')]
$cudaVersion = "latest",
[Parameter(Mandatory = $false)]
[ValidateSet('windows2019', 'windows2022', 'windows2025')]
[string]
$edition="windows",
[Parameter(Mandatory=$false)]
$edition = "windows",
[Parameter(Mandatory = $false)]
[ValidateSet('hyperv', 'process')]
[string]
$isolation="hyperv",
[Parameter(Mandatory=$false)]
$isolation = "hyperv",
[Parameter(Mandatory = $false)]
[string]
$repo="local",
[Parameter(Mandatory=$false)]
$repo = "local",
[Parameter(Mandatory = $false)]
[string]
$repoVersion="latest"
$repoVersion = "latest"
)

function TestReturnCode {
Expand All @@ -31,6 +31,7 @@ function TestReturnCode {
Push-location "$PSScriptRoot"

$rootWindowsImage = @{
"windows2025" = "mcr.microsoft.com/windows/servercore:ltsc2025"
"windows2022" = "mcr.microsoft.com/windows/servercore:ltsc2022"
"windows2019" = "mcr.microsoft.com/windows/servercore:ltsc2019"
}[$edition]
Expand All @@ -41,13 +42,13 @@ try {

$vsVer = $vsYearToVer[$vsCompilersToYear[$clVersion]]
# Override defaults in .env.
$ENV:IMAGE_NAME="$(.\generate-image-name.ps1 -clVersion $clVersion -cudaVersion $cudaVersion -edition $edition -repo $repo -repoVersion $repoVersion)"
$ENV:ISOLATION="$isolation"
$ENV:MSVC_VER="$vsVer"
$ENV:MSVC_COMPILER_VER="$clVersion"
$ENV:CUDA_VER="$cudaVersion"
$ENV:ROOT_IMAGE="$rootWindowsImage"
$ENV:BUILDKIT_PROGRESS="plain"
$ENV:IMAGE_NAME = "$(.\generate-image-name.ps1 -clVersion $clVersion -cudaVersion $cudaVersion -edition $edition -repo $repo -repoVersion $repoVersion)"
$ENV:ISOLATION = "$isolation"
$ENV:MSVC_VER = "$vsVer"
$ENV:MSVC_COMPILER_VER = "$clVersion"
$ENV:CUDA_VER = "$cudaVersion"
$ENV:ROOT_IMAGE = "$rootWindowsImage"
$ENV:BUILDKIT_PROGRESS = "plain"

Write-Output "Building $ENV:IMAGE_NAME"
Write-Output "with args:"
Expand All @@ -58,8 +59,15 @@ try {
Write-Output "ENV:CUDA_VER $ENV:CUDA_VER"
Write-Output "ENV:ROOT_IMAGE $ENV:ROOT_IMAGE"

docker pull "$ENV:ROOT_IMAGE"
docker build --file .\windows.Dockerfile --tag "$ENV:IMAGE_NAME" --isolation "$ENV:ISOLATION" --build-arg MSVC_VER="$ENV:MSVC_VER" --build-arg MSVC_COMPILER_VER="$ENV:MSVC_COMPILER_VER" --build-arg CUDA_VER="$ENV:CUDA_VER" --build-arg ROOT_IMAGE="$ENV:ROOT_IMAGE" .\image
nerdctl pull "$ENV:ROOT_IMAGE"
nerdctl build `
--file .\windows.Dockerfile `
--output "type=image,name=$ENV:IMAGE_NAME,compression=zstd,force-compression=true,platform=windows/amd64" `
--build-arg MSVC_VER="$ENV:MSVC_VER" `
--build-arg MSVC_COMPILER_VER="$ENV:MSVC_COMPILER_VER" `
--build-arg CUDA_VER="$ENV:CUDA_VER" `
--build-arg ROOT_IMAGE="$ENV:ROOT_IMAGE" `
.\image
}
catch {
Pop-Location
Expand Down