fix: log non-2xx upstream responses (status + request-id + body snippet) - #174
Merged
Conversation
ranxianglei
force-pushed
the
2026-08-19_log-upstream-errors
branch
from
August 20, 2026 01:09
0dc582a to
7772573
Compare
Owner
Author
|
LGTM — this closes exactly the observability gap from #2: the relay now logs status + request-id + a capped body snippet on the non-2xx path before Two non-blocking notes:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field report in #2: a relay answered 400 (请求参数无效) for 34 minutes; bili.log carried zero trace because non-2xx upstream responses were piped through verbatim without logging. Diagnosis had to be reconstructed by timestamp alignment against the relay request-id.
This PR makes the proxy log a warn on every non-2xx upstream response:
Pre-flight: typecheck ✓, 456/456 tests ✓, build ✓. cc issue #2