Repository navigation
feat(assistant): improve document writing and inline task feedback - #258
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
5851754
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://779f95f0.document-7hm.pages.dev |
| Branch Preview URL: | https://codex-assistant-content-revi.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] — Editor-scoped tasks now wait for real execution feedback, retain compact inline review, and preserve formatted document content. No unresolved actionable findings remain after independent review and repairs.
Summary
Risk Analysis
Design Decisions
Code Concerns
No unresolved actionable findings. Independent review identified input-specific reads ending compound tasks, readonly navigation being invalidated after success, and formatted whitespace/table verification gaps; all were repaired and rechecked. Native long-slide verification also exposed duplicated result arguments exhausting the existing context budget; a failing regression now covers compact results and retained user revisions.
Verification
Conclusion basis
tsc --noEmit --listFiles; strict lint and formatting; full Vitest suite and coverage; the seven changed assistant Playwright suites against a fresh production build, including public legacy fixtures; native text/shape/history checks, DOCX export/reopen and reverse-disable failure.