Conversation
There was a problem hiding this comment.
why do you need to add a new layout file? you could extract the texts in string.xml and write the translation
There was a problem hiding this comment.
Thank you for the review!
fragment_search.xml is located in the layout-ru-rRU folder —
this is the standard way to localize layouts in Android
(text sizes, margins for Russian language).
Should I keep the separate layout or move only strings to strings.xml?
There was a problem hiding this comment.
Translation
Line 36: app/src/main/res/layout-ru-rRU/fragment_search.xml
36.app:helperText="что вы хотите найти?"
There was a problem hiding this comment.
Original
Line 39: app/src/main/res/layout/fragment_search.xml
39.app:helperText="what are you looking for?"
There was a problem hiding this comment.
This text can be moved to strings.xml; so no need for new layout file; as there are no layout changes. It's my bad to not have all text in strings.xml
<string name="search_helper_text">что вы хотите найти?</string>
|
Removed Extraced helper text from: Line 39: Added localized string resource to:
|
2 participants
Added Russian localization to the project.