Open
Conversation
Contributor
|
ty for the PR @jktravis Only issue I see it the version dropdown is really hard to see |
Author
Contributor
|
What about I never using any toggles related to color scheme and always use "system" approach. |
Author
4f288bf to
24f70b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The dark theme that was added causes strain on some people just like the light theme for others. Prior work was done to try and use the user's system preferences. But for me, I want my system set to dark, and things that require a fair amount of reading to light for easier reading. Additionally, the current implementation never seemed to respect my settings.
Maybe we should add a theme toggle instead. This theme can be stored in local storage so it will persist.
The toggle here is placed in the top-right corner.
Light and dark look the same on toggle.