Conversation
fmassot
marked this pull request as ready for review
October 4, 2026 22:00
guilload
approved these changes
Oct 5, 2026
| .filter(|line| !is_empty_or_blank_line(line)) | ||
| } | ||
|
|
||
| fn build_doc_batch_v2_from_ndjson_body(doc_buffer: Bytes) -> Option<DocBatchV2> { |
Member
There was a problem hiding this comment.
Suggested change
| fn build_doc_batch_v2_from_ndjson_body(doc_buffer: Bytes) -> Option<DocBatchV2> { | |
| fn build_doc_batch_v2_from_ndjson_body(ndjson_body: Bytes) -> Option<DocBatchV2> { |
| .filter(|line| !is_empty_or_blank_line(line)) | ||
| } | ||
|
|
||
| fn build_doc_batch_v2_from_ndjson_body(doc_buffer: Bytes) -> Option<DocBatchV2> { |
Member
There was a problem hiding this comment.
Any chance we can abstract away the splitting and parsing part so we can reused in Pomsky for other handlers?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse the NDJSON HTTP body as
DocBatchV2.doc_bufferinstead of copying document payloads. Also adds a preallocated batch builder and benchmark; shard scaling defaults remain unchanged.Validation
Before marking ready
Body/load-shield guards across the ingest await.