feat: add notebooks onboarding modal and in-notebook MCP promo#585
Open
emrberk wants to merge 4 commits into
Open
feat: add notebooks onboarding modal and in-notebook MCP promo#585emrberk wants to merge 4 commits into
emrberk wants to merge 4 commits into
Conversation
Introduce a two-step onboarding modal that presents Notebooks and the QuestDB MCP connection on first use, alongside a collapsible in-notebook MCP promo. Visibility is tracked in localStorage and suppressed once an MCP bridge has ever connected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a first-run onboarding experience for Notebooks:
McpSetupCommand(copy-command box) and aCopyButtoniconprop so callers can supply their own glyph.How it works
Visibility is driven by a new
notebook.onboardinglocalStorage blob (mcpEverConnected,showNotebookPromo,showMcpPromo,collapseMcpPromo) exposed throughLocalStorageProvider. Pure predicates inutils/notebookOnboarding.tsdecide what shows; all onboarding surfaces are suppressed for good once an MCP bridge has ever connected (MCPBridgeProviderflipsmcpEverConnectedon first connect).Tests
notebookOnboarding.test.ts, 8 tests).yarn typecheck,yarn lint, andyarn buildall pass.🤖 Generated with Claude Code