1500 add eject option after exporting to usb#1503
Open
TheBest6337 wants to merge 2 commits into
Open
Conversation
TheBest6337
force-pushed
the
1500-add-eject-option-after-exporting-to-usb
branch
from
July 14, 2026 09:53
6f76cc4 to
350f800
Compare
TheBest6337
marked this pull request as draft
July 14, 2026 09:53
TheBest6337
marked this pull request as ready for review
July 16, 2026 08:23
TheBest6337
force-pushed
the
1500-add-eject-option-after-exporting-to-usb
branch
from
July 16, 2026 08:23
1e1707b to
6bf18ac
Compare
ninelore
requested changes
Jul 16, 2026
ninelore
left a comment
ninelore
left a comment
Member
There was a problem hiding this comment.
pls address electron lint warnings
ninelore
reviewed
Jul 18, 2026
| error: error instanceof Error ? error.message : String(error), | ||
| }; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I'd add one more fallback: sync twice to at least guarantee writes being flushed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.