GH-86: fix(github): exhaustive pagination for ListIssues/ListReleases/ListTags (30-item silent truncation) - #90
Merged
Merged
Conversation
ListIssues issued a single request (GitHub default 30 items) and ListReleases/ListTags fetched one page, silently truncating repos with more items — bringing them up to the ListPullRequests pattern (per_page=100, page loop, 50-page cap). Single-page endpoints (ListIssueComments, GetPullRequestComments, SearchPRsForIssue, SearchOpenPRsForIssue) now carry explicit doc-comments explaining why they stay single-page.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated PR created by Pilot for task GH-86.
Closes #86
Changes
GitHub Issue GH-86: fix(github): exhaustive pagination for ListIssues/ListReleases/ListTags (30-item silent truncation)
Context
SaaS pre-work S0.5. GitHub list-endpoint pagination is inconsistent (verified 2026-07-13):
ListPullRequestsand tag resolution loop up to 50 pages (sdk/integrations/github/client.go:544-556,643-660), butListIssuesissues a SINGLE request with no per_page/page params — GitHub's default returns 30 items (client.go:398-426) — andListReleases/ListTagsfetch one page (client.go:623,633). Any repo with >30 open issues is silently truncated today; the SaaS board ingest needs exhaustive listing.Implementation
In
sdk/integrations/github/client.go: bringListIssues,ListReleases, andListTagsup to theListPullRequestspattern —per_page=100, page loop with the same page cap and retry integration. Keep return shapes and exported signatures unchanged. If search/comment endpoints (client.go:254,848,967,1008) are intentionally single-page, add a doc-comment saying so explicitly rather than changing them here.Acceptance
ListIssuesreturns >100 issues completely (mocked 3-page test asserting union and page params)ListReleases/ListTagspaginate identicallyRefs
.agent/system/saas-asset-research.mdverification appendix (studio-sdk pagination finding)