fix(release): add release-assets completeness gate (GH-4523)#4524
Merged
Conversation
v2.245.1's GitHub release was reported missing pilot-linux-{amd64,arm64}.tar.gz,
which the S2 hosted-instance bootstrap and AWS box self-upgrade both depend on.
Root cause: investigated against ground truth (goreleaser workflow run
30014298612 and the live v2.245.1 release) — the linux archives were in fact
built and uploaded by that run and are present on the release today, so the
reported symptom did not reproduce from the pipeline's own logs. Regardless,
the pipeline had no automated check that would catch a genuinely incomplete
release (partial matrix, swallowed upload failure, API listing lag), so the
failure class was invisible until a downstream consumer broke.
Add scripts/verify-release-assets.sh, wired into release.yml right after the
GoReleaser step: asserts every asset in the .goreleaser.yaml build/archive
matrix exists on the tag's release (with retry/backoff for listing lag),
failing the release train loudly on any miss.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GH-4523 reported v2.245.1's GitHub release missing
pilot-linux-{amd64,arm64}.tar.gz, which the S2 hosted-instance bootstrap (pilot-console S3 bridge) and the AWS box self-upgrade both depend on.Root cause
Investigated against ground truth:
gh release view v2.245.1shows all 10 expected assets present today, including both linux tarballs.30014298612,2026-07-23T14:06:55Z) shows in its own logs thatpilot-linux-amd64.tar.gzandpilot-linux-arm64.tar.gzwere built and uploaded successfully at14:09:16Z.v2.245.1tag (no retries/re-runs), and all release assets share the same upload timestamp window (14:09–14:10Z) from that single run.So the reported symptom did not reproduce from the pipeline's own logs or the release's current state — most likely the observation happened during the ~90s upload window or hit a transient GitHub API/UI propagation delay. Regardless of the exact trigger, the pipeline had no automated check that would catch a genuinely incomplete release (partial goreleaser matrix, a swallowed upload failure, API listing lag), so that entire class of bug was invisible until a downstream consumer broke (today's S2 e2e had to fall back to v2.245.0).
Fix
scripts/verify-release-assets.sh <tag>: checks that every asset named in.goreleaser.yaml's build/archive matrix (pilot-{linux,darwin}-{amd64,arm64}.tar.gz,pilot-windows-amd64.zip,checksums.txt) exists on the tag's GitHub release, retrying up to 5x with backoff to absorb any listing lag..github/workflows/release.ymlas a "Verify release assets" step immediately after the GoReleaser step — fails the job (and the release train) loudly if anything is missing.release-desktop.ymlis a separate, slower workflow that can finish afterrelease.yml..agent/sops/operations/release-asset-completeness-gate.mdand added aFEATURE-MATRIX.mdrow.Test plan
go build ./...passes (no Go changes, sanity check only)scripts/verify-release-assets.sh v2.245.1locally against the real release — passes, confirms all 6 expected assets presentscripts/check-secret-patterns.shpassespython3 -c "import yaml; yaml.safe_load(...)")